apache / apache/cloudstack

the method `importVirtualMachineInternal(..)` now is 153 lines and takes 21 parameters.

Abierto
#11,033 1 comentario 0 reacciones 1 asignado Reclamado por @nvazquez Ver en GitHub
long-term-plan no-issue-activity type:technical-debt
Lenguaje dominante
Java
Estrellas
3.1k
Forks
1.4k
Merge medio
6 d 19 h
PR fusionados (30 d)
32

Descripción

logic looks good, but the code here needs some refactorring I think (new PR?) the method now is 153 lines and takes 21 parameters. Not sure about cyclic complexity and I really don’t want to know anymore by now.

_Originally posted by @DaanHoogland in https://github.com/apache/cloudstack/pull/10975#pullrequestreview-2931850389_

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.