apache / apache/cloudstack

the method `importVirtualMachineInternal(..)` now is 153 lines and takes 21 parameters.

Open
#11,033 1 comment 0 reactions 1 assignee Claimed by @nvazquez View on GitHub
long-term-plan no-issue-activity type:technical-debt
Dominant language
Java
Stars
3.1k
Forks
1.4k
Avg merge
6d 19h
Merged PRs (30d)
32

Description

logic looks good, but the code here needs some refactorring I think (new PR?) the method now is 153 lines and takes 21 parameters. Not sure about cyclic complexity and I really don’t want to know anymore by now.

_Originally posted by @DaanHoogland in https://github.com/apache/cloudstack/pull/10975#pullrequestreview-2931850389_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.