PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Adding pulse frequency for seismic and lightning spire trap

Open
#3,828 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

It would be nice to have pulse frequency for seismic and lightning spire trap in the Calcs tab.
Without it you can't get the exact numbers without doing the math yourself.

The math is the following:
Base pulse frequency (BPF) is 0.9 for seismic trap and for lightning spire trap it depends on the gem level.
Final pulse frequency is 1/(1/<BPF>\*(1+<increased/reduced throw speed>/100)\*(1+<more/less throw speed>/100)).

Additionally the number of pulses and pulses per second would be helpful:
# of pulses: Duration/Final pulse frequency
Pulses per second: 1/Final pulse frequency

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Calcs tab and locate the existing seismic and lightning spire trap calculations. Use the pulse-frequency formulas in the issue to determine the displayed final frequency, pulse count, and pulses per second, including the lightning trap's gem-level base frequency. Done means the Calcs tab shows these values for both traps.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.