PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Death Wish (Maw of Mischief) Uses Player Life instead of Minion Life
Open
Nobody has claimed this yet.
bug
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
- What happened?
*With Death Wish as the active skill, allocating player life nodes increases the "average damage". The code on Github also shows "output.life" as part of the damage calculation. - What were you trying to do?
- I was looking over the code to see if I could apply Death Wish's damage calculation to Dark Pact, but it looks like it's broken.
- What steps will reproduce the bug?
- Add Maw of Mischief to a character, set Death Wish to active skill, then allocate a life node (or probably do anything that increases player life)
- Does it reproduce every time?
- It's in the code, so I'd imagine so.
- Provide a build code:
- https://pastebin.com/02PPdGuG
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the Death Wish damage calculation for Maw of Mischief, focusing on the reported use of output.life. Reproduce the issue with the linked build code by allocating player life, then compare the result with minion-life changes. Done means player-life nodes no longer affect the reported Death Wish damage and the correct life value is used.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100