MIT-LCP / MIT-LCP/wfdb-python

Maybe wfdb should not read .{dat,hea,...}, instead it should be possible to directly give file contents to wfdb.

未关闭
#73 2 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

enhancement
主要语言
Jupyter Notebook
星标
853
派生
322
PR 合并指标
30 天内没有已合并 PR

描述

The fact that wfdb read files for you and that you don't have to open the file is nice, but when your files are not on the local filesystem it is much more complicated to open those files with wfdb.
For example:
Let's say all my files are on Hadoop HDFS (which is actually the case), the only way to access them in python is using a library such as hdfs3 (https://github.com/dask/hdfs3):

with hdfs.open('/user/data/100.dat') as f:
    content = f.read()
# I am now forced by wfdb to write the contents to a temporary file in the local filesystem to then open it with wfdb...

I know it would be very annoying to modify the current implementation of wfdb but I have the feeling it would be better to let the user choose its own way to give .{dat, hea, ...} contents to wfdb.
The way I see this:

  1. You have the wfdb-python library that only takes contents as input
  2. You have helper functions (downloads from physionet and read the contents for you)

Do you see a better solution?

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

issue 中没有指出源文件或测试。首先跟踪 wfdb 的读取入口以及它们如何打开 .dat、.hea 和相关文件,然后将该流程与 hdfs3 示例进行比较。当 wfdb 能够接受外部提供的文件内容而无需本地临时文件时,即可视为完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
hadoop, python
领域
data-engineering
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。