Update frames upon crosstalk filter
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 2.7k
- Forks
- 641
- PR merge metrics
- No merged PRs in 30d
Description
It might be hard to have updateFilter() replicate everything updateSelection() can do (e.g. updating frames so selections update throughout an animation) -- especially from a maintaince perspective.
Thankfully, the only theoretical difference (AFAICT) between a selection (with an opacity dim of 0) and a filter operation should be a relayout() to reflect the new axis ranges.
It might be best (at least for now) to call updateSelection() here, but with an opacityDim of 0. Then it's on the user to zoom if they want to.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at inst/htmlwidgets/plotly.js near line 411 and compare updateFilter() with updateSelection(). Trace how crosstalk filtering handles animation frames and axis ranges. Done means filtered selections update throughout an animation while the relevant axis ranges are reflected through relayout().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, r
- Domain
- data-visualization, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100