Running a process with DevTools debugger attached leaks memory
Chưa có ai nhận issue này.
- Ngôn ngữ chính
- JavaScript
- Star
- 122k
- Fork
- 37.3k
- Merge trung bình
- 4 ngày 2 giờ
- Pull request đã merge (30 ngày)
- 283
Mô tả
- Version: 14.0+ (reproduced on
v14.0.0,v14.17.0andv16.1.0) - Platform: Linux
- Tested process: https://github.com/Supinic/supibot
- Valgrind tests by: https://github.com/Leppunen
While the Chromium DevTools debugger is attached, RSS memory usage of a Node process keeps increasing without being collected. Once the debugger is detached, the memory usage flattens, however the memory is never released. When the debugger is not attached to the process in its runtime, memory allocation occurs as expected. It is entirely possible that this might not be related to Node (v8, perhaps) - however, this issue might be a good place to start a discussion.
Inspecting htop on a Raspberry Pi 3B machine:
-
Process after running for ~24 hours without a debugger attached: stable at around ~180MB RSS:

-
The same process, after attaching the debugger for ~15 minutes (with no actual user debugging active nor any logs being displayed): RSS at around ~245MB and rising:

-
After disconnecting the debugger (removing the connection, closing and re-opening the debugger window), RSS stabilizes at around ~260MB. After ~30 minutes of further activity, the RSS usage seems stable; however, the memory is not freed:

After running valgrind for various amounts of time on a different Linux machine, there seems to be an excessive amount of v8_inspector::AsyncStackTrace::capture calls. Using the Disable async stack traces option in DevTools > Settings > Debugger seems to reduce the leak somewhat, however, this wasn't reproducible across machines. Furthermore, testing the same process on Windows 10 in the same environment leads to no memory leaks.
Attached are valgrind dumps for various tested nodejs versions. Note that each dump was created with the process running for differing amounts, hence the total memory leaked will not be as relevant.
What steps will reproduce the bug?
- Set up a Node process, possibly with asynchronous stack activity
- Attach a Chrome DevTools debugger instance
- Observe a memory leak as long as the debugger is attached
How often does it reproduce? Is there a required condition?
- Only seems to reproduce on Linux, not Windows
- Might be related to async stack traces
- At first, seemed to be related to the
mariadbNPM module - but upon further testing with the module inactive, the memory leak kept occuring
What is the expected behavior?
No memory leak should occur as the debugger is being used.
What do you see instead?
Depending on the process being run, upwards of hundreds of MB of RAM will leak in a couple of minutes as the debugger is attached.
Additional information
A similar type of memory leak seems to be present in versions prior to 14.0, however, in a much smaller scale, and occuring much more slowly. Reference: nodejs/node#28787, possibly nodejs/node#28420
Hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Hướng nghiên cứu
Bắt đầu bằng cách tái hiện leak theo các bước được liệt kê trên Linux, với Chrome DevTools được gắn vào, rồi so sánh các lần chạy khi async stack traces được bật và tắt. Kiểm tra các dump Valgrind được cung cấp và hoạt động quá mức của v8_inspector::AsyncStackTrace::capture; hoàn tất có nghĩa là việc sử dụng debugger không còn gây tăng RSS kéo dài hoặc bộ nhớ chưa được giải phóng.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- javascript, nodejs
- Lĩnh vực
- performance, tooling
- Loại issue
- Lỗi
- Độ khó
- 4/5
- Thời gian dự kiến
- 3-5 ngày
- Mức độ hoạt động
- Ít trao đổi
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 45/100