nodejs / nodejs/node

Running a process with DevTools debugger attached leaks memory

Abierto
#39,063 4 comentarios 13 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

inspector memory
Lenguaje dominante
JavaScript
Estrellas
122k
Forks
37.3k
Merge medio
4 d 2 h
PR fusionados (30 d)
283

Descripción

While the Chromium DevTools debugger is attached, RSS memory usage of a Node process keeps increasing without being collected. Once the debugger is detached, the memory usage flattens, however the memory is never released. When the debugger is not attached to the process in its runtime, memory allocation occurs as expected. It is entirely possible that this might not be related to Node (v8, perhaps) - however, this issue might be a good place to start a discussion.

Inspecting htop on a Raspberry Pi 3B machine:

  • Process after running for ~24 hours without a debugger attached: stable at around ~180MB RSS:
    no debugger

  • The same process, after attaching the debugger for ~15 minutes (with no actual user debugging active nor any logs being displayed): RSS at around ~245MB and rising:
    debugger

  • After disconnecting the debugger (removing the connection, closing and re-opening the debugger window), RSS stabilizes at around ~260MB. After ~30 minutes of further activity, the RSS usage seems stable; however, the memory is not freed:
    after

After running valgrind for various amounts of time on a different Linux machine, there seems to be an excessive amount of v8_inspector::AsyncStackTrace::capture calls. Using the Disable async stack traces option in DevTools > Settings > Debugger seems to reduce the leak somewhat, however, this wasn't reproducible across machines. Furthermore, testing the same process on Windows 10 in the same environment leads to no memory leaks.

Attached are valgrind dumps for various tested nodejs versions. Note that each dump was created with the process running for differing amounts, hence the total memory leaked will not be as relevant.

valgrind.zip

What steps will reproduce the bug?
  1. Set up a Node process, possibly with asynchronous stack activity
  2. Attach a Chrome DevTools debugger instance
  3. Observe a memory leak as long as the debugger is attached
How often does it reproduce? Is there a required condition?
  • Only seems to reproduce on Linux, not Windows
  • Might be related to async stack traces
  • At first, seemed to be related to the mariadb NPM module - but upon further testing with the module inactive, the memory leak kept occuring
What is the expected behavior?

No memory leak should occur as the debugger is being used.

What do you see instead?

Depending on the process being run, upwards of hundreds of MB of RAM will leak in a couple of minutes as the debugger is attached.

Additional information

A similar type of memory leak seems to be present in versions prior to 14.0, however, in a much smaller scale, and occuring much more slowly. Reference: nodejs/node#28787, possibly nodejs/node#28420

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Empieza reproduciendo el leak mediante los pasos indicados en Linux, con Chrome DevTools adjunto, y compara las ejecuciones con async stack traces activadas y desactivadas. Inspecciona los volcados de Valgrind proporcionados y la actividad excesiva de v8_inspector::AsyncStackTrace::capture; se considera completado cuando el uso del depurador ya no provoca un crecimiento sostenido de RSS ni memoria no liberada.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript, nodejs
Área
performance, tooling
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.