nodejs / nodejs/node

Running a process with DevTools debugger attached leaks memory

Aperta
#39,063 4 commenti 13 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

inspector memory
Lingua principale
JavaScript
Stelle
122k
Fork
37.3k
Merge medio
4g 2h
PR unite (30g)
283

Descrizione

While the Chromium DevTools debugger is attached, RSS memory usage of a Node process keeps increasing without being collected. Once the debugger is detached, the memory usage flattens, however the memory is never released. When the debugger is not attached to the process in its runtime, memory allocation occurs as expected. It is entirely possible that this might not be related to Node (v8, perhaps) - however, this issue might be a good place to start a discussion.

Inspecting htop on a Raspberry Pi 3B machine:

  • Process after running for ~24 hours without a debugger attached: stable at around ~180MB RSS:
    no debugger

  • The same process, after attaching the debugger for ~15 minutes (with no actual user debugging active nor any logs being displayed): RSS at around ~245MB and rising:
    debugger

  • After disconnecting the debugger (removing the connection, closing and re-opening the debugger window), RSS stabilizes at around ~260MB. After ~30 minutes of further activity, the RSS usage seems stable; however, the memory is not freed:
    after

After running valgrind for various amounts of time on a different Linux machine, there seems to be an excessive amount of v8_inspector::AsyncStackTrace::capture calls. Using the Disable async stack traces option in DevTools > Settings > Debugger seems to reduce the leak somewhat, however, this wasn't reproducible across machines. Furthermore, testing the same process on Windows 10 in the same environment leads to no memory leaks.

Attached are valgrind dumps for various tested nodejs versions. Note that each dump was created with the process running for differing amounts, hence the total memory leaked will not be as relevant.

valgrind.zip

What steps will reproduce the bug?
  1. Set up a Node process, possibly with asynchronous stack activity
  2. Attach a Chrome DevTools debugger instance
  3. Observe a memory leak as long as the debugger is attached
How often does it reproduce? Is there a required condition?
  • Only seems to reproduce on Linux, not Windows
  • Might be related to async stack traces
  • At first, seemed to be related to the mariadb NPM module - but upon further testing with the module inactive, the memory leak kept occuring
What is the expected behavior?

No memory leak should occur as the debugger is being used.

What do you see instead?

Depending on the process being run, upwards of hundreds of MB of RAM will leak in a couple of minutes as the debugger is attached.

Additional information

A similar type of memory leak seems to be present in versions prior to 14.0, however, in a much smaller scale, and occuring much more slowly. Reference: nodejs/node#28787, possibly nodejs/node#28420

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia riproducendo il leak seguendo i passaggi elencati su Linux, con Chrome DevTools collegato, e confronta le esecuzioni con gli async stack traces abilitati e disabilitati. Ispeziona i dump di Valgrind forniti e l’attività eccessiva di v8_inspector::AsyncStackTrace::capture; il lavoro è completato quando l’uso del debugger non causa più una crescita sostenuta di RSS né memoria non rilasciata.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
javascript, nodejs
Ambito
performance, tooling
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.