nodejs / nodejs/node

Running a process with DevTools debugger attached leaks memory

Offen
#39,063 4 Kommentare 13 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

inspector memory
Vorherrschende Sprache
JavaScript
Sterne
122k
Forks
37.3k
Ø Merge
4 T. 2 Std.
Gemergte PRs (30 T.)
283

Beschreibung

While the Chromium DevTools debugger is attached, RSS memory usage of a Node process keeps increasing without being collected. Once the debugger is detached, the memory usage flattens, however the memory is never released. When the debugger is not attached to the process in its runtime, memory allocation occurs as expected. It is entirely possible that this might not be related to Node (v8, perhaps) - however, this issue might be a good place to start a discussion.

Inspecting htop on a Raspberry Pi 3B machine:

  • Process after running for ~24 hours without a debugger attached: stable at around ~180MB RSS:
    no debugger

  • The same process, after attaching the debugger for ~15 minutes (with no actual user debugging active nor any logs being displayed): RSS at around ~245MB and rising:
    debugger

  • After disconnecting the debugger (removing the connection, closing and re-opening the debugger window), RSS stabilizes at around ~260MB. After ~30 minutes of further activity, the RSS usage seems stable; however, the memory is not freed:
    after

After running valgrind for various amounts of time on a different Linux machine, there seems to be an excessive amount of v8_inspector::AsyncStackTrace::capture calls. Using the Disable async stack traces option in DevTools > Settings > Debugger seems to reduce the leak somewhat, however, this wasn't reproducible across machines. Furthermore, testing the same process on Windows 10 in the same environment leads to no memory leaks.

Attached are valgrind dumps for various tested nodejs versions. Note that each dump was created with the process running for differing amounts, hence the total memory leaked will not be as relevant.

valgrind.zip

What steps will reproduce the bug?
  1. Set up a Node process, possibly with asynchronous stack activity
  2. Attach a Chrome DevTools debugger instance
  3. Observe a memory leak as long as the debugger is attached
How often does it reproduce? Is there a required condition?
  • Only seems to reproduce on Linux, not Windows
  • Might be related to async stack traces
  • At first, seemed to be related to the mariadb NPM module - but upon further testing with the module inactive, the memory leak kept occuring
What is the expected behavior?

No memory leak should occur as the debugger is being used.

What do you see instead?

Depending on the process being run, upwards of hundreds of MB of RAM will leak in a couple of minutes as the debugger is attached.

Additional information

A similar type of memory leak seems to be present in versions prior to 14.0, however, in a much smaller scale, and occuring much more slowly. Reference: nodejs/node#28787, possibly nodejs/node#28420

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne damit, den Leak anhand der aufgeführten Schritte unter Linux mit angehängten Chrome DevTools zu reproduzieren, und vergleiche die Läufe mit aktivierten und deaktivierten async stack traces. Untersuche die bereitgestellten Valgrind-Dumps und die übermäßige Aktivität von v8_inspector::AsyncStackTrace::capture; abgeschlossen ist die Arbeit, wenn die Verwendung des Debuggers kein anhaltendes RSS-Wachstum oder nicht freigegebenen Speicher mehr verursacht.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
javascript, nodejs
Bereich
performance, tooling
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Ruhig
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.