nodejs / nodejs/github-bot

Which backport PR labels should be added by the bot?

未关闭
#120 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

question
主要语言
JavaScript
星标
305
派生
148
平均合并
9 小时 2 分钟
30 天内合并 PR
3

描述

Moving an interesting discussion ignited in https://github.com/nodejs/github-bot/issues/116 into its own issue.

Which labels should the bot automatically add when it attempts backport of PRs?

First a description of the current auto labelling logic, so we're all on the same page when discussing how backporting labels should work as a whole.

Backport attempt fails

PR patch does not land cleanly against a staging branch.

If it is a LTS staging branch dont-land-on-v${version}.x is added*, otherwise a previously added lts-watch-v${version}.x might be removed as long as the user added the watch label was the github-bot.

Backport attempt succeeds

PR patch lands cleanly against a staging branch.

If its a LTS staging branch lts-watch-v${version}.x is added, otherwise a previously added dont-land-on-v${version}.x is removed if the user who added the dont-label label was the github-bot.

Introduce explicit auto labels?

In https://github.com/nodejs/github-bot/issues/116 there were several questions and concerns related to the dont-land-on-* labels especially. Those labels are used by devs deciding what should go into staging branches, to definitely stop any unwanted PRs (described in https://github.com/nodejs/github-bot/pull/90#issuecomment-261095822 and https://github.com/nodejs/github-bot/issues/116#issuecomment-275544912). There has been raised concerns about those hard stop labels automatically, since the bot adding that label currently means it does not land cleanly, which it sounds is not the real intention of dont-land-on-* labels.

There has previously been suggested introducing explicit auto labels for these automatic backport attempts, such as auto-merge-to-v7.x-failed or similar as described in https://github.com/nodejs/github-bot/issues/116#issuecomment-275181198.

Who is these auto labels intended for?

In addition to exactly which labels the bot should add based on these backport attempts, it seems to be some confusion about who these labels are intended for. The PR author or devs staging for releases?


* dont-land-on-* labelling has recently been temporary disabled: https://github.com/nodejs/github-bot/pull/118

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

先阅读 issue 116 中链接的讨论,以及 pull request 90 和 pull request 118 中与 label 相关的上下文。然后检查此处描述的当前成功和失败标记规则,并明确哪些 label 应自动应用,以及它们是服务于 PR 作者还是 release-staging 开发者。只有在确定实现范围之前达成一致的标记策略,才能视为完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
github, javascript
领域
tooling
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。