Which backport PR labels should be added by the bot?
Ninguém assumiu esta issue ainda.
- Linguagem predominante
- JavaScript
- Estrelas
- 305
- Forks
- 148
- Merge médio
- 9h 2min
- PRs com merge (30d)
- 3
Descrição
Moving an interesting discussion ignited in https://github.com/nodejs/github-bot/issues/116 into its own issue.
Which labels should the bot automatically add when it attempts backport of PRs?
First a description of the current auto labelling logic, so we're all on the same page when discussing how backporting labels should work as a whole.
Backport attempt fails
PR patch does not land cleanly against a staging branch.
If it is a LTS staging branch dont-land-on-v${version}.x is added*, otherwise a previously added lts-watch-v${version}.x might be removed as long as the user added the watch label was the github-bot.
Backport attempt succeeds
PR patch lands cleanly against a staging branch.
If its a LTS staging branch lts-watch-v${version}.x is added, otherwise a previously added dont-land-on-v${version}.x is removed if the user who added the dont-label label was the github-bot.
Introduce explicit auto labels?
In https://github.com/nodejs/github-bot/issues/116 there were several questions and concerns related to the dont-land-on-* labels especially. Those labels are used by devs deciding what should go into staging branches, to definitely stop any unwanted PRs (described in https://github.com/nodejs/github-bot/pull/90#issuecomment-261095822 and https://github.com/nodejs/github-bot/issues/116#issuecomment-275544912). There has been raised concerns about those hard stop labels automatically, since the bot adding that label currently means it does not land cleanly, which it sounds is not the real intention of dont-land-on-* labels.
There has previously been suggested introducing explicit auto labels for these automatic backport attempts, such as auto-merge-to-v7.x-failed or similar as described in https://github.com/nodejs/github-bot/issues/116#issuecomment-275181198.
Who is these auto labels intended for?
In addition to exactly which labels the bot should add based on these backport attempts, it seems to be some confusion about who these labels are intended for. The PR author or devs staging for releases?
* dont-land-on-* labelling has recently been temporary disabled: https://github.com/nodejs/github-bot/pull/118
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Direção de pesquisa
Comece lendo a discussão vinculada em issue 116 e o contexto relacionado a labels em pull request 90 e pull request 118. Em seguida, revise as regras atuais de rotulagem de sucesso e falha descritas aqui e esclareça quais labels devem ser aplicadas automaticamente e se elas atendem aos autores de PR ou aos desenvolvedores de release-staging. Para considerar a tarefa concluída, é necessário ter uma política de rotulagem acordada antes de definir o escopo da implementação.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- github, javascript
- Domínio
- tooling
- Tipo de issue
- Funcionalidade
- Dificuldade
- 5/5
- Tempo estimado
- Mais de uma semana
- Status de atividade
- Estagnada
- Clareza
- Precisa de esclarecimento
- Facilidade para iniciantes
- 25/100