Which backport PR labels should be added by the bot?
Nessuno ha ancora preso questa issue.
- Lingua principale
- JavaScript
- Stelle
- 305
- Fork
- 148
- Merge medio
- 9h 2m
- PR unite (30g)
- 3
Descrizione
Moving an interesting discussion ignited in https://github.com/nodejs/github-bot/issues/116 into its own issue.
Which labels should the bot automatically add when it attempts backport of PRs?
First a description of the current auto labelling logic, so we're all on the same page when discussing how backporting labels should work as a whole.
Backport attempt fails
PR patch does not land cleanly against a staging branch.
If it is a LTS staging branch dont-land-on-v${version}.x is added*, otherwise a previously added lts-watch-v${version}.x might be removed as long as the user added the watch label was the github-bot.
Backport attempt succeeds
PR patch lands cleanly against a staging branch.
If its a LTS staging branch lts-watch-v${version}.x is added, otherwise a previously added dont-land-on-v${version}.x is removed if the user who added the dont-label label was the github-bot.
Introduce explicit auto labels?
In https://github.com/nodejs/github-bot/issues/116 there were several questions and concerns related to the dont-land-on-* labels especially. Those labels are used by devs deciding what should go into staging branches, to definitely stop any unwanted PRs (described in https://github.com/nodejs/github-bot/pull/90#issuecomment-261095822 and https://github.com/nodejs/github-bot/issues/116#issuecomment-275544912). There has been raised concerns about those hard stop labels automatically, since the bot adding that label currently means it does not land cleanly, which it sounds is not the real intention of dont-land-on-* labels.
There has previously been suggested introducing explicit auto labels for these automatic backport attempts, such as auto-merge-to-v7.x-failed or similar as described in https://github.com/nodejs/github-bot/issues/116#issuecomment-275181198.
Who is these auto labels intended for?
In addition to exactly which labels the bot should add based on these backport attempts, it seems to be some confusion about who these labels are intended for. The PR author or devs staging for releases?
* dont-land-on-* labelling has recently been temporary disabled: https://github.com/nodejs/github-bot/pull/118
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia leggendo la discussione collegata in issue 116 e il contesto relativo alle labels in pull request 90 e pull request 118. Esamina quindi le regole attuali per l’assegnazione delle label di successo e fallimento descritte qui, poi chiarisci quali labels dovrebbero essere assegnate automaticamente e se servono agli autori delle PR o agli sviluppatori del release-staging. Per considerare completata l’attività, è necessario concordare una policy per le label prima di poter definire l’ambito dell’implementazione.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- github, javascript
- Ambito
- tooling
- Tipo di issue
- Funzionalità
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Stato di attività
- Ferma
- Chiarezza
- Da chiarire
- Idoneità per principianti
- 25/100