nodejs / nodejs/github-bot

Which backport PR labels should be added by the bot?

Abierto
#120 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

question
Lenguaje dominante
JavaScript
Estrellas
305
Forks
148
Merge medio
9 h 2 min
PR fusionados (30 d)
3

Descripción

Moving an interesting discussion ignited in https://github.com/nodejs/github-bot/issues/116 into its own issue.

Which labels should the bot automatically add when it attempts backport of PRs?

First a description of the current auto labelling logic, so we're all on the same page when discussing how backporting labels should work as a whole.

Backport attempt fails

PR patch does not land cleanly against a staging branch.

If it is a LTS staging branch dont-land-on-v${version}.x is added*, otherwise a previously added lts-watch-v${version}.x might be removed as long as the user added the watch label was the github-bot.

Backport attempt succeeds

PR patch lands cleanly against a staging branch.

If its a LTS staging branch lts-watch-v${version}.x is added, otherwise a previously added dont-land-on-v${version}.x is removed if the user who added the dont-label label was the github-bot.

Introduce explicit auto labels?

In https://github.com/nodejs/github-bot/issues/116 there were several questions and concerns related to the dont-land-on-* labels especially. Those labels are used by devs deciding what should go into staging branches, to definitely stop any unwanted PRs (described in https://github.com/nodejs/github-bot/pull/90#issuecomment-261095822 and https://github.com/nodejs/github-bot/issues/116#issuecomment-275544912). There has been raised concerns about those hard stop labels automatically, since the bot adding that label currently means it does not land cleanly, which it sounds is not the real intention of dont-land-on-* labels.

There has previously been suggested introducing explicit auto labels for these automatic backport attempts, such as auto-merge-to-v7.x-failed or similar as described in https://github.com/nodejs/github-bot/issues/116#issuecomment-275181198.

Who is these auto labels intended for?

In addition to exactly which labels the bot should add based on these backport attempts, it seems to be some confusion about who these labels are intended for. The PR author or devs staging for releases?


* dont-land-on-* labelling has recently been temporary disabled: https://github.com/nodejs/github-bot/pull/118

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza leyendo la discusión enlazada en issue 116 y el contexto relacionado con las labels en pull request 90 y pull request 118. Revisa después las reglas actuales de etiquetado de éxitos y fallos descritas aquí, y aclara qué labels deberían aplicarse automáticamente y si sirven a los autores de PR o a los desarrolladores del release-staging. La tarea requiere contar con una política de etiquetado acordada antes de poder definir el alcance de la implementación.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github, javascript
Área
tooling
Tipo de issue
Nueva funcionalidad
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.