Which backport PR labels should be added by the bot?
Personne n'a encore pris cette issue.
- Langage dominant
- JavaScript
- Étoiles
- 305
- Forks
- 148
- Merge moyen
- 9 h 2 min
- PR mergées (30 j)
- 3
Description
Moving an interesting discussion ignited in https://github.com/nodejs/github-bot/issues/116 into its own issue.
Which labels should the bot automatically add when it attempts backport of PRs?
First a description of the current auto labelling logic, so we're all on the same page when discussing how backporting labels should work as a whole.
Backport attempt fails
PR patch does not land cleanly against a staging branch.
If it is a LTS staging branch dont-land-on-v${version}.x is added*, otherwise a previously added lts-watch-v${version}.x might be removed as long as the user added the watch label was the github-bot.
Backport attempt succeeds
PR patch lands cleanly against a staging branch.
If its a LTS staging branch lts-watch-v${version}.x is added, otherwise a previously added dont-land-on-v${version}.x is removed if the user who added the dont-label label was the github-bot.
Introduce explicit auto labels?
In https://github.com/nodejs/github-bot/issues/116 there were several questions and concerns related to the dont-land-on-* labels especially. Those labels are used by devs deciding what should go into staging branches, to definitely stop any unwanted PRs (described in https://github.com/nodejs/github-bot/pull/90#issuecomment-261095822 and https://github.com/nodejs/github-bot/issues/116#issuecomment-275544912). There has been raised concerns about those hard stop labels automatically, since the bot adding that label currently means it does not land cleanly, which it sounds is not the real intention of dont-land-on-* labels.
There has previously been suggested introducing explicit auto labels for these automatic backport attempts, such as auto-merge-to-v7.x-failed or similar as described in https://github.com/nodejs/github-bot/issues/116#issuecomment-275181198.
Who is these auto labels intended for?
In addition to exactly which labels the bot should add based on these backport attempts, it seems to be some confusion about who these labels are intended for. The PR author or devs staging for releases?
* dont-land-on-* labelling has recently been temporary disabled: https://github.com/nodejs/github-bot/pull/118
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par lire la discussion liée dans issue 116 ainsi que le contexte lié aux labels dans pull request 90 et pull request 118. Examinez ensuite les règles actuelles de labellisation des succès et des échecs décrites ici, puis clarifiez quels labels devraient être appliqués automatiquement et s’ils servent aux auteurs de PR ou aux développeurs du release-staging. La tâche ne sera considérée comme terminée qu’une fois une politique de labellisation approuvée définie avant de pouvoir cadrer l’implémentation.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- github, javascript
- Domaine
- tooling
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- À clarifier
- Accessibilité débutants
- 25/100