mapbox / mapbox/mapbox-plugins-android
Make allow text and icon overlap true by default
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 242
- Forks
- 116
- PR merge metrics
- No merged PRs in 30d
Description
Having the default value false, has led to confusion for our end users. The default value of false makes sense for symbols used in the style as labels and icons but for end-user added symbols, which are always important, we should not hide them by default. This is a breaking change and requires a semver major update.
symbolManager.setIconAllowOverlap(true);
symbolManager.setTextAllowOverlap(true);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation of symbolManager.setIconAllowOverlap(true) and symbolManager.setTextAllowOverlap(true), then inspect how their default values are defined. Change both defaults so end-user-added symbols allow overlap without explicit calls, and verify that style labels and icons retain their intended behavior. This is a breaking change requiring a semver major update.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100