hyperstack-org / hyperstack-org/hyperstack

hyper-spec evaluate_ruby should handle return of non-ruby objects

未關閉
#333 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement
主要語言
JavaScript
星號
538
分支
41
PR 合併指標
30 天內沒有已合併 PR

描述

This breaks with maximum call stack exceeded for example:

evaluate_ruby "'Element[JS.call(:eval, "(function () { return window; })();")]'"

because this returns a native js object, which cannot be processed by ruby's to_json (which is used to convert the resulting objects)

what should happen if things break is to report back some kind of details on the object type that was the result of the expression.

(Note this may already be fixed or better behaved in the new experimental version of hyper-spec)

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。