hyperstack-org / hyperstack-org/hyperstack

hyper-spec evaluate_ruby should handle return of non-ruby objects

Aperta
#333 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
JavaScript
Stelle
538
Fork
41
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

This breaks with maximum call stack exceeded for example:

evaluate_ruby "'Element[JS.call(:eval, "(function () { return window; })();")]'"

because this returns a native js object, which cannot be processed by ruby's to_json (which is used to convert the resulting objects)

what should happen if things break is to report back some kind of details on the object type that was the result of the expression.

(Note this may already be fixed or better behaved in the new experimental version of hyper-spec)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.