hyperstack-org / hyperstack-org/hyperstack

hyper-spec evaluate_ruby should handle return of non-ruby objects

未关闭
#333 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
JavaScript
星标
538
派生
41
PR 合并指标
30 天内没有已合并 PR

描述

This breaks with maximum call stack exceeded for example:

evaluate_ruby "'Element[JS.call(:eval, "(function () { return window; })();")]'"

because this returns a native js object, which cannot be processed by ruby's to_json (which is used to convert the resulting objects)

what should happen if things break is to report back some kind of details on the object type that was the result of the expression.

(Note this may already be fixed or better behaved in the new experimental version of hyper-spec)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。