hyperstack-org / hyperstack-org/hyperstack

hyper-spec evaluate_ruby should handle return of non-ruby objects

Open
#333 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
538
Forks
41
PR merge metrics
No merged PRs in 30d

Description

This breaks with maximum call stack exceeded for example:

evaluate_ruby "'Element[JS.call(:eval, "(function () { return window; })();")]'"

because this returns a native js object, which cannot be processed by ruby's to_json (which is used to convert the resulting objects)

what should happen if things break is to report back some kind of details on the object type that was the result of the expression.

(Note this may already be fixed or better behaved in the new experimental version of hyper-spec)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.