hyperstack-org / hyperstack-org/hyperstack

hyper-spec evaluate_ruby should handle return of non-ruby objects

Abierto
#333 1 comentario 0 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
JavaScript
Estrellas
538
Forks
41
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

This breaks with maximum call stack exceeded for example:

evaluate_ruby "'Element[JS.call(:eval, "(function () { return window; })();")]'"

because this returns a native js object, which cannot be processed by ruby's to_json (which is used to convert the resulting objects)

what should happen if things break is to report back some kind of details on the object type that was the result of the expression.

(Note this may already be fixed or better behaved in the new experimental version of hyper-spec)

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.