hardbyte / hardbyte/python-can
SLCAN, Robotell, socketcan, serial, seeedstudio use fileno property-like function for i/o
オープン
- 主要言語
- Python
- スター
- 1.6k
- フォーク
- 697
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
In the interfaces SLCAN, Robotell, socketcan, serial and seeedstudio there is a property-like function called fileno. This is not marked as property and is used in notifier test for i/o.
As written in the BusABC description there should be no "custom" property.
Using this method leaves a coverage gap on Windows AND on Linux.
The notifier will not use the asyncio loop in add_bus but tries to clear the loop in stop and do not join the reader.
The special handling for these interfaces should be removed and only the recv method used (as in all other interfaces) and the notifier reworked.
コントリビューションガイド
評価
この issue はまだ評価されていません。