hardbyte / hardbyte/python-can
SLCAN, Robotell, socketcan, serial, seeedstudio use fileno property-like function for i/o
- 主要語言
- Python
- 星號
- 1.6k
- 分支
- 697
- PR 合併指標
- 30 天內沒有已合併 PR
描述
In the interfaces SLCAN, Robotell, socketcan, serial and seeedstudio there is a property-like function called fileno. This is not marked as property and is used in notifier test for i/o.
As written in the BusABC description there should be no "custom" property.
Using this method leaves a coverage gap on Windows AND on Linux.
The notifier will not use the asyncio loop in add_bus but tries to clear the loop in stop and do not join the reader.
The special handling for these interfaces should be removed and only the recv method used (as in all other interfaces) and the notifier reworked.
貢獻指南
研究方向
Start with the SLCAN, Robotell, socketcan, serial, and seeedstudio interfaces, then read the notifier test and the notifier add_bus and stop paths. Verify how recv is used across the other interfaces, remove the special fileno handling, and confirm notifier behavior and coverage on both Windows and Linux.
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- networking
- Issue 類型
- 重構
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 42/100