hardbyte / hardbyte/python-can
SLCAN, Robotell, socketcan, serial, seeedstudio use fileno property-like function for i/o
- Lingua principale
- Python
- Stelle
- 1.6k
- Fork
- 697
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
In the interfaces SLCAN, Robotell, socketcan, serial and seeedstudio there is a property-like function called fileno. This is not marked as property and is used in notifier test for i/o.
As written in the BusABC description there should be no "custom" property.
Using this method leaves a coverage gap on Windows AND on Linux.
The notifier will not use the asyncio loop in add_bus but tries to clear the loop in stop and do not join the reader.
The special handling for these interfaces should be removed and only the recv method used (as in all other interfaces) and the notifier reworked.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.