hardbyte / hardbyte/python-can

SLCAN, Robotell, socketcan, serial, seeedstudio use fileno property-like function for i/o

未关闭
#752 6 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
1.6k
派生
697
PR 合并指标
30 天内没有已合并 PR

描述

In the interfaces SLCAN, Robotell, socketcan, serial and seeedstudio there is a property-like function called fileno. This is not marked as property and is used in notifier test for i/o.
As written in the BusABC description there should be no "custom" property.
Using this method leaves a coverage gap on Windows AND on Linux.

The notifier will not use the asyncio loop in add_bus but tries to clear the loop in stop and do not join the reader.

The special handling for these interfaces should be removed and only the recv method used (as in all other interfaces) and the notifier reworked.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。