googleapis / googleapis/google-cloud-java
[sdk-platform-java] Remove internet request in unit tests
Open
priority: p2
type: feature request
- Dominant language
- Java
- Stars
- 2.1k
- Forks
- 1.2k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 154
Description
The unit tests in `hermetic_build/release_note_generation/tests/generate_pr_description_unit_tests.py` have real `git clone` and `git checkout`. However, it is not a best practice for unit tests to depend on internet request as it is slow and flaky.
We should mock these operations to make the unit tests quick and deterministic.
Contributor guide
Assessment
This issue has not been assessed yet.