google / google/GoogleSignIn-iOS
Refactor and improve `GIDEMMSupport` parameters and tests
- 主要言語
- Objective-C
- スター
- 750
- フォーク
- 282
- 平均マージ
- 2日 15時間
- マージ済み PR(30日)
- 9
説明
This issue tracks follow-up improvements identified during the review of PR #608. We need to address the following technical debt and testing improvements:
- [ ] **Handle nested data structures:** Ensure that the `parametersWithParameters` function safely drops key parameters that contain values like a nested array.
- [ ] **Standardize `UIDevice` mocking:** Fix the tests that are swizzling `UIDevice` to "Not Do That," or ensure all tests are doing it the same way. Relying on the real `UIDevice` will make tests non-hermetic.
- [ ] **Uplevel tests to the public API:** Consider upleveling the new `GIDEMMSupport` unit tests to test against the public API instead of testing internal classes in isolation.
コントリビューションガイド
調査の方向性
Start by reading the GIDEMMSupport implementation and its existing unit tests, especially parametersWithParameters and the tests that swizzle UIDevice. Check how the public API exposes this behavior and identify which tests rely on real device state. Done means nested-array key parameters are safely dropped, UIDevice mocking is consistent and hermetic, and coverage exercises the public API where appropriate.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- objective-c
- 領域
- authentication, mobile-dev, testing
- issue の種類
- リファクタリング
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 静か
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 48/100