google / google/GoogleSignIn-iOS

Refactor and improve `GIDEMMSupport` parameters and tests

Abierto
#611 0 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement triage
Lenguaje dominante
Objective-C
Estrellas
750
Forks
282
Merge medio
2 d 15 h
PR fusionados (30 d)
9

Descripción

This issue tracks follow-up improvements identified during the review of PR #608. We need to address the following technical debt and testing improvements:

- [ ] **Handle nested data structures:** Ensure that the `parametersWithParameters` function safely drops key parameters that contain values like a nested array.
- [ ] **Standardize `UIDevice` mocking:** Fix the tests that are swizzling `UIDevice` to "Not Do That," or ensure all tests are doing it the same way. Relying on the real `UIDevice` will make tests non-hermetic.
- [ ] **Uplevel tests to the public API:** Consider upleveling the new `GIDEMMSupport` unit tests to test against the public API instead of testing internal classes in isolation.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start by reading the GIDEMMSupport implementation and its existing unit tests, especially parametersWithParameters and the tests that swizzle UIDevice. Check how the public API exposes this behavior and identify which tests rely on real device state. Done means nested-array key parameters are safely dropped, UIDevice mocking is consistent and hermetic, and coverage exercises the public API where appropriate.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
objective-c
Área
authentication, mobile-dev, testing
Tipo de issue
Refactorización
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
48/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.