google / google/GoogleSignIn-iOS
Refactor and improve `GIDEMMSupport` parameters and tests
- 主要语言
- Objective-C
- 星标
- 750
- 派生
- 282
- 平均合并
- 2 天 15 小时
- 30 天内合并 PR
- 9
描述
This issue tracks follow-up improvements identified during the review of PR #608. We need to address the following technical debt and testing improvements:
- [ ] **Handle nested data structures:** Ensure that the `parametersWithParameters` function safely drops key parameters that contain values like a nested array.
- [ ] **Standardize `UIDevice` mocking:** Fix the tests that are swizzling `UIDevice` to "Not Do That," or ensure all tests are doing it the same way. Relying on the real `UIDevice` will make tests non-hermetic.
- [ ] **Uplevel tests to the public API:** Consider upleveling the new `GIDEMMSupport` unit tests to test against the public API instead of testing internal classes in isolation.
贡献指南
调研方向
首先阅读 GIDEMMSupport 的实现及其现有的单元测试,尤其是 parametersWithParameters 和对 UIDevice 进行 swizzle 的测试。检查公共 API 如何暴露这一行为,并确定哪些测试依赖真实的设备状态。完成标准是:嵌套数组键参数能够被安全丢弃,UIDevice 的 mocking 保持一致且 hermetic,并在适当情况下通过 coverage 覆盖公共 API。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- objective-c
- 领域
- authentication, mobile-dev, testing
- Issue 类型
- 重构
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 48/100