google / google/GoogleSignIn-iOS

Refactor and improve `GIDEMMSupport` parameters and tests

Ouverte
#611 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement triage
Langage dominant
Objective-C
Étoiles
750
Forks
282
Merge moyen
2 j 15 h
PR mergées (30 j)
9

Description

This issue tracks follow-up improvements identified during the review of PR #608. We need to address the following technical debt and testing improvements:

- [ ] **Handle nested data structures:** Ensure that the `parametersWithParameters` function safely drops key parameters that contain values like a nested array.
- [ ] **Standardize `UIDevice` mocking:** Fix the tests that are swizzling `UIDevice` to "Not Do That," or ensure all tests are doing it the same way. Relying on the real `UIDevice` will make tests non-hermetic.
- [ ] **Uplevel tests to the public API:** Consider upleveling the new `GIDEMMSupport` unit tests to test against the public API instead of testing internal classes in isolation.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start by reading the GIDEMMSupport implementation and its existing unit tests, especially parametersWithParameters and the tests that swizzle UIDevice. Check how the public API exposes this behavior and identify which tests rely on real device state. Done means nested-array key parameters are safely dropped, UIDevice mocking is consistent and hermetic, and coverage exercises the public API where appropriate.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
objective-c
Domaine
authentication, mobile-dev, testing
Type d'issue
Refactorisation
Difficulté
4/5
Temps estimé
3-5 jours
Activité
Calme
Clarté
Plutôt claire
Accessibilité débutants
48/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.