getsentry / getsentry/sentry-javascript

`getDefaultIntegrations` no longer extends the base set

オープン 初心者向け
#24,039 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
Cloudflare Workers javascript
主要言語
TypeScript
スター
8.7k
フォーク
1.8k
平均マージ
1日 17時間
マージ済み PR(30日)
523

説明

`packages/cloudflare/src/baseSdk.ts:45` documents that "`getDefaultIntegrations` in `sdk.ts` extends this set with the integrations that do depend on Node.js APIs". `sdk.ts:13` is:

```ts
export function getDefaultIntegrations(options: CloudflareOptions): Integration[] {
return getBaseDefaultIntegrations(options);
}
```

The two sets are identical. `packages/cloudflare/src/request.ts:9` then tells users to "pass `defaultIntegrations: getDefaultIntegrations(options)` in `options` to get the full set instead", which is now a no-op.

**Work item.** Work out whether a `nodejs_compat`-only integration was dropped or never added. Then either restore it or correct both doc comments. Do not leave advice in the docs that does nothing.

**Prior art ***(related history only)*. No issue, but the cause is clear from the history. getsentry/sentry-javascript#21881 added a separate `/nodejs_compat` entrypoint with the larger integration set, and getsentry/sentry-javascript#22900 "Make the nodejs_compat entrypoint the default" folded it into the default entrypoint and removed it, closing [#18803](). The two sets became identical at that point and the doc comments were not updated. This is documentation cleanup, not lost functionality.

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Read packages/cloudflare/src/baseSdk.ts:45, sdk.ts:13, and request.ts:9, then compare the default integration sets and the related history described in the issue. Update the comments so they accurately describe the identical sets and remove any advice that has no effect; confirm the documentation is consistent and no functionality is changed.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
typescript
領域
documentation
issue の種類
ドキュメント
難易度
2/5
見積もり時間
1〜3時間
活発さ
活発
明瞭さ
明確に書かれている
初心者へのやさしさ
84/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。