getsentry / getsentry/sentry-javascript

`getDefaultIntegrations` no longer extends the base set

未关闭 适合新手
#24,039 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Cloudflare Workers javascript
主要语言
TypeScript
星标
8.7k
派生
1.8k
平均合并
1 天 17 小时
30 天内合并 PR
523

描述

`packages/cloudflare/src/baseSdk.ts:45` documents that "`getDefaultIntegrations` in `sdk.ts` extends this set with the integrations that do depend on Node.js APIs". `sdk.ts:13` is:

```ts
export function getDefaultIntegrations(options: CloudflareOptions): Integration[] {
return getBaseDefaultIntegrations(options);
}
```

The two sets are identical. `packages/cloudflare/src/request.ts:9` then tells users to "pass `defaultIntegrations: getDefaultIntegrations(options)` in `options` to get the full set instead", which is now a no-op.

**Work item.** Work out whether a `nodejs_compat`-only integration was dropped or never added. Then either restore it or correct both doc comments. Do not leave advice in the docs that does nothing.

**Prior art ***(related history only)*. No issue, but the cause is clear from the history. getsentry/sentry-javascript#21881 added a separate `/nodejs_compat` entrypoint with the larger integration set, and getsentry/sentry-javascript#22900 "Make the nodejs_compat entrypoint the default" folded it into the default entrypoint and removed it, closing [#18803](). The two sets became identical at that point and the doc comments were not updated. This is documentation cleanup, not lost functionality.

贡献指南

打开贡献指南

调研方向

Read packages/cloudflare/src/baseSdk.ts:45, sdk.ts:13, and request.ts:9, then compare the default integration sets and the related history described in the issue. Update the comments so they accurately describe the identical sets and remove any advice that has no effect; confirm the documentation is consistent and no functionality is changed.

由索引模型根据 Issue 内容生成。

评估

技术栈
typescript
领域
documentation
Issue 类型
文档
难度
2/5
预计耗时
1-3 小时
活跃度
活跃
描述清晰度
描述清楚
新手友好度
84/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。