getsentry / getsentry/sentry-javascript
`getDefaultIntegrations` no longer extends the base set
- Lingua principale
- TypeScript
- Stelle
- 8.7k
- Fork
- 1.8k
- Merge medio
- 1g 17h
- PR unite (30g)
- 523
Descrizione
`packages/cloudflare/src/baseSdk.ts:45` documents that "`getDefaultIntegrations` in `sdk.ts` extends this set with the integrations that do depend on Node.js APIs". `sdk.ts:13` is:
```ts
export function getDefaultIntegrations(options: CloudflareOptions): Integration[] {
return getBaseDefaultIntegrations(options);
}
```
The two sets are identical. `packages/cloudflare/src/request.ts:9` then tells users to "pass `defaultIntegrations: getDefaultIntegrations(options)` in `options` to get the full set instead", which is now a no-op.
**Work item.** Work out whether a `nodejs_compat`-only integration was dropped or never added. Then either restore it or correct both doc comments. Do not leave advice in the docs that does nothing.
**Prior art ***(related history only)*. No issue, but the cause is clear from the history. getsentry/sentry-javascript#21881 added a separate `/nodejs_compat` entrypoint with the larger integration set, and getsentry/sentry-javascript#22900 "Make the nodejs_compat entrypoint the default" folded it into the default entrypoint and removed it, closing [#18803](). The two sets became identical at that point and the doc comments were not updated. This is documentation cleanup, not lost functionality.
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Read packages/cloudflare/src/baseSdk.ts:45, sdk.ts:13, and request.ts:9, then compare the default integration sets and the related history described in the issue. Update the comments so they accurately describe the identical sets and remove any advice that has no effect; confirm the documentation is consistent and no functionality is changed.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- typescript
- Ambito
- documentation
- Tipo di issue
- Documentazione
- Difficoltà
- 2/5
- Tempo stimato
- 1-3 ore
- Stato di attività
- Attiva
- Chiarezza
- Specificata chiaramente
- Idoneità per principianti
- 84/100