getsentry / getsentry/sentry-javascript

`getDefaultIntegrations` no longer extends the base set

Ouverte Adaptée aux débutants
#24,039 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Cloudflare Workers javascript
Langage dominant
TypeScript
Étoiles
8.7k
Forks
1.8k
Merge moyen
1 j 17 h
PR mergées (30 j)
523

Description

`packages/cloudflare/src/baseSdk.ts:45` documents that "`getDefaultIntegrations` in `sdk.ts` extends this set with the integrations that do depend on Node.js APIs". `sdk.ts:13` is:

```ts
export function getDefaultIntegrations(options: CloudflareOptions): Integration[] {
return getBaseDefaultIntegrations(options);
}
```

The two sets are identical. `packages/cloudflare/src/request.ts:9` then tells users to "pass `defaultIntegrations: getDefaultIntegrations(options)` in `options` to get the full set instead", which is now a no-op.

**Work item.** Work out whether a `nodejs_compat`-only integration was dropped or never added. Then either restore it or correct both doc comments. Do not leave advice in the docs that does nothing.

**Prior art ***(related history only)*. No issue, but the cause is clear from the history. getsentry/sentry-javascript#21881 added a separate `/nodejs_compat` entrypoint with the larger integration set, and getsentry/sentry-javascript#22900 "Make the nodejs_compat entrypoint the default" folded it into the default entrypoint and removed it, closing [#18803](). The two sets became identical at that point and the doc comments were not updated. This is documentation cleanup, not lost functionality.

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Read packages/cloudflare/src/baseSdk.ts:45, sdk.ts:13, and request.ts:9, then compare the default integration sets and the related history described in the issue. Update the comments so they accurately describe the identical sets and remove any advice that has no effect; confirm the documentation is consistent and no functionality is changed.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
typescript
Domaine
documentation
Type d'issue
Documentation
Difficulté
2/5
Temps estimé
1-3 heures
Activité
Active
Clarté
Clairement spécifiée
Accessibilité débutants
84/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.