flathub / flathub/com.visualstudio.code
App logs to stderr "Warning: 'ms-enable-electron-run-as-node' is not in the list of known options, but still passed to Electron/Chromium."
- 主要言語
- Shell
- スター
- 217
- フォーク
- 82
- 平均マージ
- 1日 7時間
- マージ済み PR(30日)
- 1
説明
When running this application, the above is written to stderr, which seems to be [because this option is no longer supported by vscode](https://github.com/microsoft/vscode/issues/137510#issuecomment-1851387783) as of Chromium v29, [which upstream began using in May last year](https://github.com/microsoft/vscode/pull/209818). I believe the following change can be made in these lines (https://github.com/flathub/com.visualstudio.code/blob/e0e3f21b28330f31729e7b6eed5341d5e4390f0e/code.sh#L69-L70):
```diff
- --ms-enable-electron-run-as-node --extensions-dir=${XDG_DATA_HOME}/vscode/extensions \
- "$@" ${WARNING_FILE}
+ --extensions-dir=${XDG_DATA_HOME}/vscode/extensions "$@" ${WARNING_FILE}
```
This could be achieved by applying the above diff, or by simply reverting ad2d7c8edbf45d7e9e6a779d2e5a72c1761a6491, which added the now-defunct option.
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
調査の方向性
Inspect code.sh at lines 69-70, where the Electron launch arguments are assembled. Remove the obsolete option as described, then run the application and verify that stderr no longer contains the known-options warning.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- electron, shell
- 領域
- desktop
- issue の種類
- バグ
- 難易度
- 1/5
- 見積もり時間
- 1時間未満
- 活発さ
- 停滞
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 65/100