flathub / flathub/com.visualstudio.code

App logs to stderr "Warning: 'ms-enable-electron-run-as-node' is not in the list of known options, but still passed to Electron/Chromium."

Open
#563 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
217
Forks
82
Avg merge
1d 7h
Merged PRs (30d)
1

Description

When running this application, the above is written to stderr, which seems to be [because this option is no longer supported by vscode](https://github.com/microsoft/vscode/issues/137510#issuecomment-1851387783) as of Chromium v29, [which upstream began using in May last year](https://github.com/microsoft/vscode/pull/209818). I believe the following change can be made in these lines (https://github.com/flathub/com.visualstudio.code/blob/e0e3f21b28330f31729e7b6eed5341d5e4390f0e/code.sh#L69-L70):

```diff
- --ms-enable-electron-run-as-node --extensions-dir=${XDG_DATA_HOME}/vscode/extensions \
- "$@" ${WARNING_FILE}
+ --extensions-dir=${XDG_DATA_HOME}/vscode/extensions "$@" ${WARNING_FILE}
```

This could be achieved by applying the above diff, or by simply reverting ad2d7c8edbf45d7e9e6a779d2e5a72c1761a6491, which added the now-defunct option.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.