flathub / flathub/com.visualstudio.code

App logs to stderr "Warning: 'ms-enable-electron-run-as-node' is not in the list of known options, but still passed to Electron/Chromium."

Ouverte Adaptée aux débutants
#563 0 commentaires 2 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Shell
Étoiles
217
Forks
82
Merge moyen
1 j 7 h
PR mergées (30 j)
1

Description

When running this application, the above is written to stderr, which seems to be [because this option is no longer supported by vscode](https://github.com/microsoft/vscode/issues/137510#issuecomment-1851387783) as of Chromium v29, [which upstream began using in May last year](https://github.com/microsoft/vscode/pull/209818). I believe the following change can be made in these lines (https://github.com/flathub/com.visualstudio.code/blob/e0e3f21b28330f31729e7b6eed5341d5e4390f0e/code.sh#L69-L70):

```diff
- --ms-enable-electron-run-as-node --extensions-dir=${XDG_DATA_HOME}/vscode/extensions \
- "$@" ${WARNING_FILE}
+ --extensions-dir=${XDG_DATA_HOME}/vscode/extensions "$@" ${WARNING_FILE}
```

This could be achieved by applying the above diff, or by simply reverting ad2d7c8edbf45d7e9e6a779d2e5a72c1761a6491, which added the now-defunct option.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Inspect code.sh at lines 69-70, where the Electron launch arguments are assembled. Remove the obsolete option as described, then run the application and verify that stderr no longer contains the known-options warning.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
electron, shell
Domaine
desktop
Type d'issue
Bug
Difficulté
1/5
Temps estimé
Moins d'une heure
Activité
À l'abandon
Clarté
Clairement spécifiée
Accessibilité débutants
65/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.