flathub / flathub/com.visualstudio.code

App logs to stderr "Warning: 'ms-enable-electron-run-as-node' is not in the list of known options, but still passed to Electron/Chromium."

未关闭
#563 0 条评论 2 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Shell
星标
217
派生
82
平均合并
1 天 7 小时
30 天内合并 PR
1

描述

When running this application, the above is written to stderr, which seems to be [because this option is no longer supported by vscode](https://github.com/microsoft/vscode/issues/137510#issuecomment-1851387783) as of Chromium v29, [which upstream began using in May last year](https://github.com/microsoft/vscode/pull/209818). I believe the following change can be made in these lines (https://github.com/flathub/com.visualstudio.code/blob/e0e3f21b28330f31729e7b6eed5341d5e4390f0e/code.sh#L69-L70):

```diff
- --ms-enable-electron-run-as-node --extensions-dir=${XDG_DATA_HOME}/vscode/extensions \
- "$@" ${WARNING_FILE}
+ --extensions-dir=${XDG_DATA_HOME}/vscode/extensions "$@" ${WARNING_FILE}
```

This could be achieved by applying the above diff, or by simply reverting ad2d7c8edbf45d7e9e6a779d2e5a72c1761a6491, which added the now-defunct option.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。