code-corps / code-corps/code-corps-ember

Description of a category item does not change color on selection

Open
#1,092 0 comments 0 reactions 0 assignees View on GitHub
bug Difficulty: Easy
Dominant language
JavaScript
Stars
120
Forks
75
PR merge metrics
No merged PRs in 30d

Description

# Problem

From https://github.com/code-corps/code-corps-ember/pull/1079#discussion_r102404681

>The `description` text is always using the `$text--light` (`#666`) color and does not switch to `$default-color` (`#08A8FC` when selected.

The PR introduced a minor bug. The `iconClass` is bound to the icon element alone and nothing is bound to the `p` element which holds the description. That means that the `p.selected` style can no longer apply.

The component itself should be bound to the `iconClass` class property and styles should be rewritten so they apply to both the icon and the `p` element.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.