aws / aws/aws-step-functions-data-science-sdk-python

Feature Request: Improved Support/Documentation for PipelineModel

Open
#143 0 comments 0 reactions 0 assignees View on GitHub
documentation
Dominant language
Python
Stars
299
Forks
84
PR merge metrics
No merged PRs in 30d

Description

While an example includes use of PipelineModel: https://github.com/aws/aws-step-functions-data-science-sdk-python/blob/main/src/stepfunctions/template/pipeline/inference.py#L128

This is a no-op: https://github.com/aws/aws-step-functions-data-science-sdk-python/blob/main/src/stepfunctions/template/pipeline/inference.py#L142

Setting the parameters property results in no changes to the CreateModel API call.
Instead, this method should be called: https://github.com/aws/aws-step-functions-data-science-sdk-python/blob/master/src/stepfunctions/steps/states.py#L201

which performs the desired update: self.fields[Field.Parameters.value] = params

Overall, while the example should likely be updated and documentation provided on use of PipelineModel, this method of parameter updating feels like a workaround. Ideally, ModelStep could take PipelineModel as input.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.