appsmithorg / appsmithorg/appsmith
Better abstractions in widget operations
Đang mở
Task
UI Building Product
- Ngôn ngữ chính
- TypeScript
- Star
- 40.9k
- Fork
- 4.8k
- Merge trung bình
- 1 ngày 22 giờ
- Pull request đã merge (30 ngày)
- 45
Mô tả
Can we ensure that we don't leak abstractions here? Technically, the WidgetOperationSaga should be agnostic to the widget being deleted. Since the tab widget has special handling, we should have a function called `deleteWidget` in the `BaseWidget` class with an empty implementation. If any widget requires a special handling, the specific widget should override it's implementation of the `delete` function to fire the specific event.
_Originally posted by @mohanarpit in https://github.com/appsmithorg/appsmith/pull/3218#discussion_r582884240_
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.