appsmithorg / appsmithorg/appsmith

Better abstractions in widget operations

Ouverte
#3,393 1 commentaire 0 réactions 1 personne assignée Réclamée par @riodeuno Voir sur GitHub
Task UI Building Product
Langage dominant
TypeScript
Étoiles
40.9k
Forks
4.8k
Merge moyen
1 j 22 h
PR mergées (30 j)
45

Description

Can we ensure that we don't leak abstractions here? Technically, the WidgetOperationSaga should be agnostic to the widget being deleted. Since the tab widget has special handling, we should have a function called `deleteWidget` in the `BaseWidget` class with an empty implementation. If any widget requires a special handling, the specific widget should override it's implementation of the `delete` function to fire the specific event.

_Originally posted by @mohanarpit in https://github.com/appsmithorg/appsmith/pull/3218#discussion_r582884240_

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.