appsmithorg / appsmithorg/appsmith
Better abstractions in widget operations
オープン
Task
UI Building Product
- 主要言語
- TypeScript
- スター
- 40.9k
- フォーク
- 4.8k
- 平均マージ
- 1日 22時間
- マージ済み PR(30日)
- 45
説明
Can we ensure that we don't leak abstractions here? Technically, the WidgetOperationSaga should be agnostic to the widget being deleted. Since the tab widget has special handling, we should have a function called `deleteWidget` in the `BaseWidget` class with an empty implementation. If any widget requires a special handling, the specific widget should override it's implementation of the `delete` function to fire the specific event.
_Originally posted by @mohanarpit in https://github.com/appsmithorg/appsmith/pull/3218#discussion_r582884240_
コントリビューションガイド
評価
この issue はまだ評価されていません。