appsmithorg / appsmithorg/appsmith

Better abstractions in widget operations

Aperta
#3,393 1 commento 0 reazioni 1 assegnatario Rivendicata da @riodeuno Vedi su GitHub
Task UI Building Product
Lingua principale
TypeScript
Stelle
40.9k
Fork
4.8k
Merge medio
1g 22h
PR unite (30g)
45

Descrizione

Can we ensure that we don't leak abstractions here? Technically, the WidgetOperationSaga should be agnostic to the widget being deleted. Since the tab widget has special handling, we should have a function called `deleteWidget` in the `BaseWidget` class with an empty implementation. If any widget requires a special handling, the specific widget should override it's implementation of the `delete` function to fire the specific event.

_Originally posted by @mohanarpit in https://github.com/appsmithorg/appsmith/pull/3218#discussion_r582884240_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.