akiran / akiran/react-foundation-apps
Modal and layers
未关闭
- 主要语言
- JavaScript
- 星标
- 291
- 派生
- 45
- PR 合并指标
- 30 天内没有已合并 PR
描述
First, thanks for the library! Good work!
Looking at your code, it seems that you implement modal dialogs by rendering them in the DOM and showing or hiding them. This does seem to be the Angular / Foundation for Apps way.
However, in React modals should use layers to render them on demand.
See:
https://github.com/facebook/react/issues/379
and (the solution)
https://github.com/pieterv/react-layers
What do you think?
Peter
贡献指南
这个仓库没有索引到贡献指南
评估
这个 Issue 还没有评估数据。