akiran / akiran/react-foundation-apps
Modal and layers
Abierto
- Lenguaje dominante
- JavaScript
- Estrellas
- 291
- Forks
- 45
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
First, thanks for the library! Good work!
Looking at your code, it seems that you implement modal dialogs by rendering them in the DOM and showing or hiding them. This does seem to be the Angular / Foundation for Apps way.
However, in React modals should use layers to render them on demand.
See:
https://github.com/facebook/react/issues/379
and (the solution)
https://github.com/pieterv/react-layers
What do you think?
Peter
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Evaluación
Este issue todavía no se ha evaluado.