akiran / akiran/react-foundation-apps
Modal and layers
Aperta
- Lingua principale
- JavaScript
- Stelle
- 291
- Fork
- 45
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
First, thanks for the library! Good work!
Looking at your code, it seems that you implement modal dialogs by rendering them in the DOM and showing or hiding them. This does seem to be the Angular / Foundation for Apps way.
However, in React modals should use layers to render them on demand.
See:
https://github.com/facebook/react/issues/379
and (the solution)
https://github.com/pieterv/react-layers
What do you think?
Peter
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.