akiran / akiran/react-foundation-apps
Modal and layers
Open
- Dominant language
- JavaScript
- Stars
- 291
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
First, thanks for the library! Good work!
Looking at your code, it seems that you implement modal dialogs by rendering them in the DOM and showing or hiding them. This does seem to be the Angular / Foundation for Apps way.
However, in React modals should use layers to render them on demand.
See:
https://github.com/facebook/react/issues/379
and (the solution)
https://github.com/pieterv/react-layers
What do you think?
Peter
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.