akiran / akiran/react-foundation-apps
Modal and layers
Ouverte
- Langage dominant
- JavaScript
- Étoiles
- 291
- Forks
- 45
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
First, thanks for the library! Good work!
Looking at your code, it seems that you implement modal dialogs by rendering them in the DOM and showing or hiding them. This does seem to be the Angular / Foundation for Apps way.
However, in React modals should use layers to render them on demand.
See:
https://github.com/facebook/react/issues/379
and (the solution)
https://github.com/pieterv/react-layers
What do you think?
Peter
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.