SteamFrameControllerProfile.FinishSetup should use ThumbstickControl instead of StickControl

Open Beginner friendly
#12 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
csharp, unity
Domain
game-dev

Research direction

Open com.valvesoftware.openxr.utils/Runtime/Interactions/SteamFrameControllerProfile.cs at the FinishSetup call around line 247. Confirm that the child-control lookup uses StickControl while the path provides a Vector2Control when USE_STICK_CONTROL_THUMBSTICKS is not set; done means using ThumbstickControl so device creation no longer throws in that situation.

Written by the indexing model from the issue text.

Description

https://github.com/ValveSoftware/Unity/blob/main/com.valvesoftware.openxr.utils/Runtime/Interactions/SteamFrameControllerProfile.cs#L247

This call to GetChildControl should use ThumbstickControl instead of StickControl to support situations where USE_STICK_CONTROL_THUMBSTICKS is not set. Currently, an exception will be thrown when the device is created because it looks for a StickControl at a path where there is a Vector2Control.

Dominant language
C#
Stars
64
Forks
3
Avg merge
1m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ValveSoftware/Unity

All issues in ValveSoftware/Unity

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.